chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h - Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things: (Closed)

Patch Set: Address xdai@ comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

diff --git a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

index 68f2cc1a225a4cc62d2024ed2ab4e966a60e5773..847e0012fe40d2b1a4ac423b94bfb3675fa9feac 100644

--- a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

+++ b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

@@ -88,7 +88,7 @@ class CupsPrintersHandler : public ::settings::SettingsPageUIHandler,

// chromeos::PrinterDiscoverer::Observer override:

void OnPrintersFound(const std::vector<Printer>& printers) override;

- void OnDiscoveryDone() override;

+ void OnDiscoveryInitialScanDone() override;

// Invokes debugd to add the printer to CUPS. If |ipp_everywhere| is true,

// automatic configuration will be attempted and |ppd_path| is ignored.