chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js - Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js

Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things: (Closed)

Patch Set: Address xdai@ comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html ('K') | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html ('k') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js

diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js

index ecf3558a5e0d8cb1cc9c93d75cf36c8a863d4fa9..f12795a22bd264badbb037d19a907a8416a33f80 100644

--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js

+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js

@@ -14,7 +14,7 @@ Polymer({

/** @type {!CupsPrinterInfo} */

- selectedPrinter: {

+ newPrinter: {

type: Object,

notify: true,

@@ -25,7 +25,7 @@ Polymer({

* @private

onSelect_: function(event) {

- this.selectedPrinter = event.model.item;

+ this.newPrinter = event.model.item;

});