Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2790573003: [MD settings] subpage arrows in languages section (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] subpage arrows in languages section This CL changes the Custom spelling and Manage input methods rows to be subpage-arrow rows. They already navigated to subpages, they just didn't have the (current) styling to indicate that. BUG=703910 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2790573003 Cr-Commit-Position: refs/heads/master@{#460908} Committed: https://chromium.googlesource.com/chromium/src/+/fc60335a19fee4a00be07804f8e8251028f171d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M chrome/browser/resources/settings/languages_page/languages_page.html View 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 8 months ago (2017-03-30 19:17:47 UTC) #5
stevenjb
lgtm
3 years, 8 months ago (2017-03-30 21:25:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790573003/1
3 years, 8 months ago (2017-03-30 22:19:50 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 22:27:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc60335a19fee4a00be07804f8e8...

Powered by Google App Engine
This is Rietveld 408576698