Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2790553002: Remove opaque frame buffer in destructor of GbmBufferBase. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=706848 Review-Url: https://codereview.chromium.org/2790553002 Cr-Commit-Position: refs/heads/master@{#460788} Committed: https://chromium.googlesource.com/chromium/src/+/565131ae89b7f786dad9d8743975bc628ee24888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
yhanada
Could you review this CL? Thanks!
3 years, 8 months ago (2017-03-30 10:49:57 UTC) #4
reveman
lgtm please mention in the description of the CL what change caused this leak to ...
3 years, 8 months ago (2017-03-30 10:54:09 UTC) #5
yhanada
On 2017/03/30 10:54:09, reveman wrote: > lgtm > > please mention in the description of ...
3 years, 8 months ago (2017-03-30 10:57:51 UTC) #7
yhanada
+dnicoara for owner review
3 years, 8 months ago (2017-03-30 10:59:11 UTC) #9
dnicoara
lgtm
3 years, 8 months ago (2017-03-30 14:23:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790553002/1
3 years, 8 months ago (2017-03-30 16:08:30 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/565131ae89b7f786dad9d8743975bc628ee24888
3 years, 8 months ago (2017-03-30 16:23:26 UTC) #18
Daniele Castagna
3 years, 8 months ago (2017-03-30 16:24:30 UTC) #19
Message was sent while issue was closed.
Thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698