|
|
Chromium Code Reviews
DescriptionRemove opaque frame buffer in destructor of GbmBufferBase.
Opaque frame buffer was introduced in http://crrev.com/2743403005.
This causes CTS tests failures by OOM killer.
BUG=706848
Review-Url: https://codereview.chromium.org/2790553002
Cr-Commit-Position: refs/heads/master@{#460788}
Committed: https://chromium.googlesource.com/chromium/src/+/565131ae89b7f786dad9d8743975bc628ee24888
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yhanada@chromium.org changed reviewers: + dcastagna@chromium.org, reveman@chromium.org
Could you review this CL? Thanks!
lgtm please mention in the description of the CL what change caused this leak to appear so it's easy to tell how long it has existed and if the fix needs to be merged to any branches.
Description was changed from ========== Remove opaque frame buffer in destructor of GbmBufferBase. This causes CTS tests failures by OOM killer. BUG=b/36630915 ========== to ========== Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=b/36630915 ==========
On 2017/03/30 10:54:09, reveman wrote: > lgtm > > please mention in the description of the CL what change caused this leak to > appear so it's easy to tell how long it has existed and if the fix needs to be > merged to any branches. Thank you for your quick review. Updated the description.
yhanada@chromium.org changed reviewers: + dnicoara@chromium.org
+dnicoara for owner review
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=b/36630915 ========== to ========== Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=706848 ==========
The CQ bit was checked by yhanada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490890066124630, "parent_rev":
"eff95516605a04f45c09c603fc247d0da414a003", "commit_rev":
"565131ae89b7f786dad9d8743975bc628ee24888"}
Message was sent while issue was closed.
Description was changed from ========== Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=706848 ========== to ========== Remove opaque frame buffer in destructor of GbmBufferBase. Opaque frame buffer was introduced in http://crrev.com/2743403005. This causes CTS tests failures by OOM killer. BUG=706848 Review-Url: https://codereview.chromium.org/2790553002 Cr-Commit-Position: refs/heads/master@{#460788} Committed: https://chromium.googlesource.com/chromium/src/+/565131ae89b7f786dad9d8743975... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/565131ae89b7f786dad9d8743975...
Message was sent while issue was closed.
Thanks for fixing this! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
