Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2790523004: memory-infra: refactoring to extract MemoryDumpProviderInfo class (Closed)

Created:
3 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Nico, ssid
CC:
chromium-reviews, Dirk Pranke, tfarina, wfh+watch_chromium.org, vmpstr+watch_chromium.org, agrieve+watch_chromium.org, tracing+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: refactoring to extract MemoryDumpProviderInfo class Non-functional refactoring in preparation of upcoming CLs. This simply extract the MemoryDumpProviderInfo class in its own translation unit. BUG=703184 TBR=thakis@chromium.org Review-Url: https://codereview.chromium.org/2790523004 Cr-Commit-Position: refs/heads/master@{#461156} Committed: https://chromium.googlesource.com/chromium/src/+/9a9a8c2542a81a6410d88e75650e907611acc630

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -98 lines) Patch
M base/BUILD.gn View 2 chunks +4 lines, -3 lines 1 comment Download
M base/trace_event/memory_dump_manager.h View 3 chunks +2 lines, -65 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 3 chunks +2 lines, -30 lines 0 comments Download
A base/trace_event/memory_dump_provider_info.h View 1 chunk +107 lines, -0 lines 0 comments Download
A base/trace_event/memory_dump_provider_info.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Primiano Tucci (use gerrit)
small cl, nothing interesting, but this is a precondition for next one: https://codereview.chromium.org/2790523004/ https://codereview.chromium.org/2790523004/diff/1/base/BUILD.gn File ...
3 years, 8 months ago (2017-03-31 16:41:40 UTC) #6
ssid
lgtm.
3 years, 8 months ago (2017-03-31 17:02:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790523004/1
3 years, 8 months ago (2017-03-31 17:05:48 UTC) #9
Primiano Tucci (use gerrit)
TBR thakis for adding 2 lines in base/BUILD.gn (not worth your time to click on ...
3 years, 8 months ago (2017-03-31 17:07:42 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 17:19:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a9a8c2542a81a6410d88e75650e...

Powered by Google App Engine
This is Rietveld 408576698