Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2790493008: Disable media.android.tvc_tbmv2 on most devices (Closed)

Created:
3 years, 8 months ago by johnchen
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, CalebRouleau
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable media.android.tvc_tbmv2 on most devices The media.andoid.tough_video_cases_tmbv2 benchmark is failing on devices other than Nexus 5X. Disabling on those devices until the root cause can be found. BUG=707286 Review-Url: https://codereview.chromium.org/2790493008 Cr-Commit-Position: refs/heads/master@{#461298} Committed: https://chromium.googlesource.com/chromium/src/+/6c053334d79f15e04910119bd174d45fbf5fd613

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add crbug to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/perf/benchmarks/media.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
johnchen
PTAL
3 years, 8 months ago (2017-03-31 21:33:57 UTC) #2
CalebRouleau
lgtm LGTM
3 years, 8 months ago (2017-03-31 23:04:05 UTC) #4
CalebRouleau
https://codereview.chromium.org/2790493008/diff/1/tools/perf/benchmarks/media.py File tools/perf/benchmarks/media.py (right): https://codereview.chromium.org/2790493008/diff/1/tools/perf/benchmarks/media.py#newcode146 tools/perf/benchmarks/media.py:146: # Disabling on those devices until we figure out ...
3 years, 8 months ago (2017-03-31 23:04:45 UTC) #5
nednguyen
lgtm
3 years, 8 months ago (2017-03-31 23:04:58 UTC) #6
johnchen
On 2017/03/31 23:04:45, crouleau wrote: > https://codereview.chromium.org/2790493008/diff/1/tools/perf/benchmarks/media.py > File tools/perf/benchmarks/media.py (right): > > https://codereview.chromium.org/2790493008/diff/1/tools/perf/benchmarks/media.py#newcode146 > ...
3 years, 8 months ago (2017-03-31 23:11:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790493008/20001
3 years, 8 months ago (2017-03-31 23:13:13 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 01:26:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c053334d79f15e04910119bd174...

Powered by Google App Engine
This is Rietveld 408576698