Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2790463004: Ash Tray: Fix ip address to work for VPN (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ash Tray: Fix ip address to work for VPN BUG=706085 Review-Url: https://codereview.chromium.org/2790463004 Cr-Commit-Position: refs/heads/master@{#461176} Committed: https://chromium.googlesource.com/chromium/src/+/e1342f7eddf4feddaac3c061bdfa78502e500228

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stevenjb
Feel free to just integrate this into your CL if that will be simpler.
3 years, 8 months ago (2017-03-30 18:28:26 UTC) #2
stevenjb
On 2017/03/30 18:28:26, stevenjb wrote: > Feel free to just integrate this into your CL ...
3 years, 8 months ago (2017-03-30 18:29:20 UTC) #3
Evan Stade
https://codereview.chromium.org/2790463004/diff/1/ash/common/system/chromeos/network/network_state_list_detailed_view.cc File ash/common/system/chromeos/network/network_state_list_detailed_view.cc (right): https://codereview.chromium.org/2790463004/diff/1/ash/common/system/chromeos/network/network_state_list_detailed_view.cc#newcode415 ash/common/system/chromeos/network/network_state_list_detailed_view.cc:415: ip_address = network->ip_address(); I guess this change is all ...
3 years, 8 months ago (2017-03-30 23:58:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790463004/20001
3 years, 8 months ago (2017-03-31 16:37:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/352672)
3 years, 8 months ago (2017-03-31 17:39:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790463004/20001
3 years, 8 months ago (2017-03-31 17:50:29 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 18:29:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1342f7eddf4feddaac3c061bdfa...

Powered by Google App Engine
This is Rietveld 408576698