Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2790453003: Android: Make incremental install work for two <instrumentation> (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Make incremental install work for two <instrumentation> This happens in the case of junit4 Review-Url: https://codereview.chromium.org/2790453003 Cr-Commit-Position: refs/heads/master@{#460839} Committed: https://chromium.googlesource.com/chromium/src/+/4e5061771986fd0d506d21f33a0d8fdb065add92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M build/android/incremental_install/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/incremental_install/generate_android_manifest.py View 2 chunks +13 lines, -6 lines 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java View 2 chunks +9 lines, -5 lines 0 comments Download
A build/android/incremental_install/java/org/chromium/incrementalinstall/SecondInstrumentation.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
agrieve
On 2017/03/30 15:48:30, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:wnwen@chromium.org 🚉
3 years, 8 months ago (2017-03-30 15:49:12 UTC) #2
Peter Wen
lgtm We've had a second instrumentation, but what about a third instrumentation? <insert meme> 🐼
3 years, 8 months ago (2017-03-30 15:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790453003/1
3 years, 8 months ago (2017-03-30 15:55:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/261321)
3 years, 8 months ago (2017-03-30 18:00:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790453003/1
3 years, 8 months ago (2017-03-30 18:12:59 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 18:58:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e5061771986fd0d506d21f33a0d...

Powered by Google App Engine
This is Rietveld 408576698