DescriptionRevert of Cleaner fall-back stack capture for --enable-heap-profiling=native. (patchset #4 id:80001 of https://codereview.chromium.org/2757123002/ )
Reason for revert:
Broke Chrome for Android official builds (see crbug.com/706698), due to new dependency on debugging_flags.h header.
Original issue's description:
> Cleaner fall-back stack capture for --enable-heap-profiling=native.
>
> This generalizes the fall-back to using base::debug::StackTrace to
> capture stack traces in builds which lack frame pointers, allowing
> native heap profiling to generate useful data, albeit with a more
> significant performance penalty.
>
> Changes made in the earlier patch for native heap profiling stack
> capture under Windows are un-done in favour of the following:
> 1. MemoryDumpManager always allows native heap profiling[1].
> 2. HeapProfilerAllocationContextTracker chooses whether to use
> base::debug::StackTrace or TraceStackFramePointers() based on
> the value of HAVE_TRACE_STACK_FRAME_POINTERS().
> 3. HAVE_STACK_FRAME_POINTERS is no longer defined in configurations
> which lack frame pointers[2].
>
> [1] Though note that only certain build configs actually support
> the necessary allocator shims; this will be addressed later.
> [2] Frame pointers are typically only available in enable_profiling
> or Debug builds.
>
> BUG=686208
>
> Review-Url: https://codereview.chromium.org/2757123002
> Cr-Commit-Position: refs/heads/master@{#460311}
> Committed: https://chromium.googlesource.com/chromium/src/+/22b017b9b241c47db8cf25c57c89c0b0d7fcfbe2
TBR=dskiba@chromium.org,primiano@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686208
Review-Url: https://codereview.chromium.org/2790443002
Cr-Commit-Position: refs/heads/master@{#460679}
Committed: https://chromium.googlesource.com/chromium/src/+/3731f7d26c0d826826453efc211d7902bc61e3d9
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|