Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2790363002: Move C functions out of ContentSuggestionsMediator (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin, lody
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move C functions out of ContentSuggestionsMediator This CL allows a clearer separation between the ContentSuggestionsMediator and its helper functions. BUG=694159 Review-Url: https://codereview.chromium.org/2790363002 Cr-Commit-Position: refs/heads/master@{#462031} Committed: https://chromium.googlesource.com/chromium/src/+/085f11ae2fc898d313f00907dd7ee1334ce2d9e4

Patch Set 1 #

Patch Set 2 : Fix line break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -99 lines) Patch
M ios/chrome/browser/content_suggestions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 2 chunks +1 line, -99 lines 0 comments Download
A ios/chrome/browser/content_suggestions/mediator_util.h View 1 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/browser/content_suggestions/mediator_util.mm View 1 chunk +100 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-04 08:26:44 UTC) #2
gambard
PTAL.
3 years, 8 months ago (2017-04-04 16:04:09 UTC) #4
lody
lgtm
3 years, 8 months ago (2017-04-04 16:08:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790363002/20001
3 years, 8 months ago (2017-04-05 06:56:48 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-05 06:56:50 UTC) #9
stkhapugin
lgtm
3 years, 8 months ago (2017-04-05 09:50:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790363002/20001
3 years, 8 months ago (2017-04-05 09:50:26 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 10:46:46 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/085f11ae2fc898d313f00907dd7e...

Powered by Google App Engine
This is Rietveld 408576698