Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2790323003: Revert of Prerender: Disable prefetch if there's an appcache. (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, blink-reviews-html_chromium.org, Yoav Weiss, loading-reviews+parser_chromium.org, gavinp+prer_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prerender: Disable prefetch if there's an appcache. (patchset #7 id:120001 of https://codereview.chromium.org/2642733002/ ) Reason for revert: Appears to make NoStatePrefetchBrowserTest.AppCacheHtmlInitialized and NoStatePrefetchBrowserTest.AppCacheRegistered flaky. Original issue's description: > Prerender: Disable prefetch if there's an appcache. > > Stops the preload scanner if an appcache manifest is detected and the document > is prefetching. > > BUG=632368 > > Review-Url: https://codereview.chromium.org/2642733002 > Cr-Commit-Position: refs/heads/master@{#461081} > Committed: https://chromium.googlesource.com/chromium/src/+/d741ab419a18a996643c568434e0a756eaf7bee6 TBR=droger@chromium.org,csharrison@chromium.org,michaeln@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632368, 707522 Review-Url: https://codereview.chromium.org/2790323003 Cr-Commit-Position: refs/heads/master@{#461662} Committed: https://chromium.googlesource.com/chromium/src/+/c17879886146bbb41cb4435f275ebdbc0f70903a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -141 lines) Patch
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 6 chunks +16 lines, -106 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/prerender/appcache.manifest View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/prerender/appcache.manifest.mock-http-headers View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/prerender/prefetch_appcache.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Timothy Loh
Created Revert of Prerender: Disable prefetch if there's an appcache.
3 years, 8 months ago (2017-04-04 06:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790323003/1
3 years, 8 months ago (2017-04-04 06:59:17 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 08:41:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c17879886146bbb41cb4435f275e...

Powered by Google App Engine
This is Rietveld 408576698