Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Issue 2790213004: Don't try to update incessently when Shell APK version is out of date. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
index 3cff61d0a10b1c391df28970eef09eeaf45c5658..42ecd8b5ebc083b427f7c10d1421686ea12e993c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
@@ -287,7 +287,7 @@ public class WebApkUpdateManager implements WebApkUpdateDataFetcher.Observer {
if (!ChromeWebApkHost.areUpdatesEnabled()) return false;
- if (isShellApkVersionOutOfDate(info)) return true;
+ if (isShellApkVersionOutOfDate(info) && mStorage.shouldRequestShellApkUpdate()) return true;
pkotwicz 2017/04/04 22:29:57 Can we remove this if(){} statement entirely? I th
Xi Han 2017/04/05 17:19:09 I think 3 day is also good, but we'd better not wa
return mStorage.shouldCheckForUpdate();
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698