Don't try to update incessently when Shell APK version is out of date.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.graphics.Bitmap;
 import android.text.TextUtils;
@@ skipping 269 matching lines @@
             return false;
         }
 
         if (CommandLine.getInstance().hasSwitch(
                     ChromeSwitches.CHECK_FOR_WEB_MANIFEST_UPDATE_ON_STARTUP)) {
             return true;
         }
 
         if (!ChromeWebApkHost.areUpdatesEnabled()) return false;
 
-        if (isShellApkVersionOutOfDate(info)) return true;
+        if (isShellApkVersionOutOfDate(info) && mStorage.shouldRequestShellApkUpdate()) return true;

[pkotwicz, 2017/04/04 22:29:57]

Can we remove this if(){} statement entirely? I think that it is OK to only
check updates every 3 days.

I think that your CL changes the logic to try updates every 2 days if the
ShellAPK is updated. A 2 day interval is very similar to a 3 day interval.

Of course, if the update frequency is relaxed, it is possible that a user needs
to wait for 30 days before getting an update. Right now the ShellAPK updates we
are making are non critical. Waiting for 30 days does not sound that bad

[Xi Han, 2017/04/05 17:19:09]

I think 3 day is also good, but we'd better not wait for 30 days for the shell
update.

 
         return mStorage.shouldCheckForUpdate();
     }
 
     /**
      * Updates {@link WebappDataStorage} with the time of the latest WebAPK update and whether the
      * WebAPK update succeeded.
      */
     private static void recordUpdate(WebappDataStorage storage,
             @WebApkInstallResult.WebApkInstallResultEnum int result, boolean relaxUpdates) {
@@ skipping 65 matching lines @@
 
         recordUpdate(storage, result, relaxUpdates);
     }
 
     private static native void nativeUpdateAsync(String id, String startUrl, String scope,
             String name, String shortName, String bestIconUrl, Bitmap bestIcon, String[] iconUrls,
             String[] iconHashes, int displayMode, int orientation, long themeColor,
             long backgroundColor, String manifestUrl, String webApkPackage, int webApkVersion,
             boolean isManifestStale);
 }