Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2790203003: Correct ImageBitmapOptions.colorSpaceConversion data type (Closed)

Created:
3 years, 8 months ago by zakerinasab
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct ImageBitmapOptions.colorSpaceConversion data type In Blink, the type for ImageBitmapOptions#colorSpaceConversion is ImageBitmapColorSpaceConversion, but in the spec (https://html.spec.whatwg.org/#imagebitmapoptions) the type is ColorSpaceConversion. This CL matches Blink interface with the spec. BUG=707898 Review-Url: https://codereview.chromium.org/2790203003 Cr-Commit-Position: refs/heads/master@{#461722} Committed: https://chromium.googlesource.com/chromium/src/+/2cd37ce8e602d9b864f0476d3e470cc8439d8ad6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Justin Novosad
lgtm
3 years, 8 months ago (2017-04-04 14:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790203003/1
3 years, 8 months ago (2017-04-04 14:36:13 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:18:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cd37ce8e602d9b864f0476d3e47...

Powered by Google App Engine
This is Rietveld 408576698