cc: Dump scheduler and tile manager state when commit is blocked.

cc: Dump scheduler and tile manager state when commit is blocked.

This adds a DumpWithoutCrashing call that's posted from the main thread
to the impl thread. This is done after a 20s timeout which is chosen to
be less than the renderer hung timeout (30s) but still large enough. The
crash dump includes scheduler and tile manager state on the stack.

R=vmpstr@chromium.org
BUG=668892, 622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2790173005
Cr-Commit-Position: refs/heads/master@{#463711}
Committed: https://chromium.googlesource.com/chromium/src/+/c7d72f32028bc11312db3d9604e3a70da73168b7

[sunnyps, 2017-04-04 23:12:44]

Description was changed from

==========
WIP cc: Dump state for begin main frame hangs.

BUG=
==========

to

==========
WIP cc: Dump state for begin main frame hangs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-04-08 01:04:50]

Description was changed from

==========
WIP cc: Dump state for begin main frame hangs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Dump scheduler and tile manager state when commit is blocked.

This adds a DumpWithoutCrashing call that's posted from the main thread
to the impl thread. This is done after a 20s timeout which is chosen to
be less than the renderer hung timeout (30s) but still large enough. The
crash dump includes scheduler and tile manager state on the stack.

R=vmpstr@chromium.org
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-04-08 01:05:17]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[sunnyps, 2017-04-08 01:05:43]

sunnyps@chromium.org changed reviewers:
+ vmpstr@chromium.org

[sunnyps, 2017-04-08 01:05:43]

ptal

[commit-bot: I haz the power, 2017-04-08 01:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 02:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 02:24:42]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2017-04-11 01:06:46]

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc
File cc/trees/proxy_impl.cc (right):

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc#...
cc/trees/proxy_impl.cc:235: char stack_string[20000] = "\0";
nit: = ""; (or = {}; or = {0};)

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc
File cc/trees/proxy_main.cc (right):

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
cc/trees/proxy_main.cc:271: constexpr base::TimeDelta kDumpDelay =
base::TimeDelta::FromSeconds(20);
nit: static?

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
cc/trees/proxy_main.cc:276: completion.Wait();
nit: this will DCHECK since we've already waited. Maybe only set waited = true
if we didn't time out in the completion event?

[sunnyps, 2017-04-11 01:53:40]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 01:54:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:46:36]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2017-04-11 18:20:31]

lgtm

[sunnyps, 2017-04-11 18:22:48]

Hmmm, I thought I sent out my replies yesterday, but I see that you've already
l-g-t-m'd so all is good :)

Thanks!

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc
File cc/trees/proxy_impl.cc (right):

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc#...
cc/trees/proxy_impl.cc:235: char stack_string[20000] = "\0";
On 2017/04/11 01:06:46, vmpstr wrote:
> nit: = ""; (or = {}; or = {0};)

Done.

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc
File cc/trees/proxy_main.cc (right):

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
cc/trees/proxy_main.cc:271: constexpr base::TimeDelta kDumpDelay =
base::TimeDelta::FromSeconds(20);
On 2017/04/11 01:06:46, vmpstr wrote:
> nit: static?

Done.

https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
cc/trees/proxy_main.cc:276: completion.Wait();
On 2017/04/11 01:06:46, vmpstr wrote:
> nit: this will DCHECK since we've already waited. Maybe only set waited = true
> if we didn't time out in the completion event?

Changed TimedWait to set waited_ to false if wait failed.

[sunnyps, 2017-04-11 18:22:57]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:23:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-04-11 18:36:19]

On 2017/04/11 18:22:48, sunnyps wrote:
> Hmmm, I thought I sent out my replies yesterday, but I see that you've already
> l-g-t-m'd so all is good :)
> 
> Thanks!

Hehe, I just saw a new patchset so decided to review :D

> 
> https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc
> File cc/trees/proxy_impl.cc (right):
> 
>
https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_impl.cc#...
> cc/trees/proxy_impl.cc:235: char stack_string[20000] = "\0";
> On 2017/04/11 01:06:46, vmpstr wrote:
> > nit: = ""; (or = {}; or = {0};)
> 
> Done.
> 
> https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc
> File cc/trees/proxy_main.cc (right):
> 
>
https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
> cc/trees/proxy_main.cc:271: constexpr base::TimeDelta kDumpDelay =
> base::TimeDelta::FromSeconds(20);
> On 2017/04/11 01:06:46, vmpstr wrote:
> > nit: static?
> 
> Done.
> 
>
https://codereview.chromium.org/2790173005/diff/40001/cc/trees/proxy_main.cc#...
> cc/trees/proxy_main.cc:276: completion.Wait();
> On 2017/04/11 01:06:46, vmpstr wrote:
> > nit: this will DCHECK since we've already waited. Maybe only set waited =
true
> > if we didn't time out in the completion event?
> 
> Changed TimedWait to set waited_ to false if wait failed.

[commit-bot: I haz the power, 2017-04-11 19:07:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491934977499890,
"parent_rev": "be26518ed4e8a2966c919a93b488689374b17d42", "commit_rev":
"c7d72f32028bc11312db3d9604e3a70da73168b7"}

[commit-bot: I haz the power, 2017-04-11 19:08:49]

Description was changed from

==========
cc: Dump scheduler and tile manager state when commit is blocked.

This adds a DumpWithoutCrashing call that's posted from the main thread
to the impl thread. This is done after a 20s timeout which is chosen to
be less than the renderer hung timeout (30s) but still large enough. The
crash dump includes scheduler and tile manager state on the stack.

R=vmpstr@chromium.org
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Dump scheduler and tile manager state when commit is blocked.

This adds a DumpWithoutCrashing call that's posted from the main thread
to the impl thread. This is done after a 20s timeout which is chosen to
be less than the renderer hung timeout (30s) but still large enough. The
crash dump includes scheduler and tile manager state on the stack.

R=vmpstr@chromium.org
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2790173005
Cr-Commit-Position: refs/heads/master@{#463711}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7d72f32028bc11312db3d9604e3...
==========

[commit-bot: I haz the power, 2017-04-11 19:08:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c7d72f32028bc11312db3d9604e3...