Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2790173002: Fix flaky hr-timestamp/input-events.html (Closed)

Created:
3 years, 8 months ago by dtapuska
Modified:
3 years, 8 months ago
Reviewers:
mustaq
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky hr-timestamp/input-events.html Add some additional precision fudge factor. The flakiness has been reduced since change https://codereview.chromium.org/2784913002. But now getting a few flakes likely due to precision issues. assert_approx_equals: expected 42.56 +/- 0.005 but got 42.555 BUG=706494 Review-Url: https://codereview.chromium.org/2790173002 Cr-Commit-Position: refs/heads/master@{#461716} Committed: https://chromium.googlesource.com/chromium/src/+/86a9036f5ae27bdc2c0dfb710a26745ea2820644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
dtapuska
3 years, 8 months ago (2017-04-03 15:43:05 UTC) #3
mustaq
lgtm
3 years, 8 months ago (2017-04-03 17:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790173002/1
3 years, 8 months ago (2017-04-03 17:57:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/422245)
3 years, 8 months ago (2017-04-03 19:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790173002/1
3 years, 8 months ago (2017-04-04 13:58:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:04:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86a9036f5ae27bdc2c0dfb710a26...

Powered by Google App Engine
This is Rietveld 408576698