Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2790143003: Cache Storage API tests: Fix WPT test bugs, remove redundant local copies (Closed)

Created:
3 years, 8 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache Storage API tests: Fix WPT test bugs, remove redundant local copies * Use promise_rejects consistently and fix parameters. * Don't use .php in upstreamed tests. * Add additional test cases from blink's copies. * Tightened up assertions about result array ordering. * Remove blink's redundant copies of tests. I left the credentials tests alone since Blink is mid-deprecation. BUG=655479 R=jkarlin@chromium.org Review-Url: https://codereview.chromium.org/2790143003 Cr-Commit-Position: refs/heads/master@{#462593} Committed: https://chromium.googlesource.com/chromium/src/+/44c004f971b6a204a8802b0fad4cac0401b17771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -2951 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/resources/test-helpers.js View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-add.js View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-delete.js View 2 chunks +74 lines, -25 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-keys.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-match.js View 4 chunks +98 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-matchAll.js View 8 chunks +86 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-put.js View 1 chunk +18 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage.js View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js View 1 chunk +106 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-keys.https.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-add.https-expected.txt View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-keys.https.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-storage.https-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-add.https-expected.txt View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-keys.https.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-put.https-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-storage.https-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/common.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/blank.html View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/common-worker.js View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/fetch-status.php View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/iframe.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js View 1 chunk +0 lines, -302 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js View 1 chunk +0 lines, -265 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-delete.js View 1 chunk +0 lines, -164 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js View 1 chunk +0 lines, -192 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js View 1 chunk +0 lines, -297 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-put.js View 1 chunk +0 lines, -306 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage.js View 1 chunk +0 lines, -239 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-keys.js View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js View 1 chunk +0 lines, -243 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-delete.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-keys.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-match.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-put.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-keys.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-match.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/ignore-search-with-credentials.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-add.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-add-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-delete.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-keys.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-match.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-put.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-keys.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-match.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/sandboxed-iframes.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/window/sandboxed-iframes-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-add.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-add-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-delete.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-keys.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-match.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-put.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-keys.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-match.html View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jsbell
jkarlin@ - can you take a look?
3 years, 8 months ago (2017-04-04 00:07:13 UTC) #3
jkarlin
lgtm!
3 years, 8 months ago (2017-04-05 18:10:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790143003/1
3 years, 8 months ago (2017-04-06 18:19:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/44c004f971b6a204a8802b0fad4cac0401b17771
3 years, 8 months ago (2017-04-06 19:53:01 UTC) #11
jeffcarp
On 2017/04/06 at 19:53:01, commit-bot wrote: > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/44c004f971b6a204a8802b0fad4cac0401b17771 A WPT ...
3 years, 8 months ago (2017-04-06 21:54:55 UTC) #12
jsbell
On 2017/04/06 21:54:55, jeffcarp wrote: > On 2017/04/06 at 19:53:01, commit-bot wrote: > > Committed ...
3 years, 8 months ago (2017-04-07 16:56:20 UTC) #13
jsbell
3 years, 8 months ago (2017-04-07 19:13:10 UTC) #14
Message was sent while issue was closed.
On 2017/04/07 16:56:20, jsbell wrote:
> Looks like all the failures are c/o cache-keys.js (all the variants).
> 
> I'll see if I can repro the flakiness in FF and if the test can be fixed.

My dev box is offline at the moment; the failures look like FF not returning
keys in insertion order. I haven't found a bug for that yet, though...

Powered by Google App Engine
This is Rietveld 408576698