wip

wip

BUG=677933

[satorux1, 2017-04-03 07:50:06]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 07:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 08:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 08:50:52]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-04-04 22:19:44]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org, mmenke@chromium.org

[eroman, 2017-04-04 22:19:45]

https://codereview.chromium.org/2790073002/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/2790073002/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_io_data.cc:1177:
base::MakeUnique<chromeos::FileRequestInterceptor>());
You will want mmenke to review this change. In fact he can probably advise you
better on the overall approach.

In general I would say we don't want to use an interceptor for this. If we
substitute at this level, how about changing the location a few lines above:

  job_factory->SetProtocolHandler(url::kFileScheme, ...);

And injecting the ChromeOS specific file:// handler there.

That said, I am not sure I understand why the NetworkDelegate based approach did
not work. My understanding is you ran into problems with OfflinePageRequestJob
on Android? I don't know anything about that class, but that would suggest it
isn't using the file job appropriately, or can be modified in how it calls.

Lastly, I should point out that either of these approaches is only going to
allow blacklisting paths from within profile-initiated requests. file://URLs
that come from other contexts may not flow through that. Notably, I expect that
if you specify a file:// URL for a PAC script it will not go through any of
these checks as it is using a different URLRequestContext.

[mmenke, 2017-04-04 22:43:58]

I assume this isn't ready for review?  No review request published, no docs?  I
also don't have access to the associated bug.

[satorux1, 2017-04-05 05:17:38]

eroman: thank you for the feedback. let me move the discussion back to the bug.

[satorux1, 2017-04-21 05:42:27]

Description was changed from

==========
wip

BUG=677933
==========

to

==========
wip

BUG=677933
==========