wip

chrome/browser/profiles/profile_io_data.cc

Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 6bda90fa8177a9b711bf21a9ad79e6985f933a35..a0d6abf234b6295130ce6e59cf6767e948f90c70 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -129,6 +129,7 @@
 #include "chrome/browser/chromeos/certificate_provider/certificate_provider.h"
 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"
 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h"
+#include "chrome/browser/chromeos/file_request_interceptor.h"
 #include "chrome/browser/chromeos/fileapi/external_file_protocol_handler.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
 #include "chrome/browser/chromeos/net/cert_verify_proc_chromeos.h"
@@ -1172,6 +1173,8 @@ ProfileIOData::SetUpJobFactoryDefaults(
             profile_params_->profile));
     DCHECK(set_protocol);
   }
+  request_interceptors.push_back(
+      base::MakeUnique<chromeos::FileRequestInterceptor>());

[eroman, 2017/04/04 22:19:45]

You will want mmenke to review this change. In fact he can probably advise you
better on the overall approach.

In general I would say we don't want to use an interceptor for this. If we
substitute at this level, how about changing the location a few lines above:

  job_factory->SetProtocolHandler(url::kFileScheme, ...);

And injecting the ChromeOS specific file:// handler there.

That said, I am not sure I understand why the NetworkDelegate based approach did
not work. My understanding is you ran into problems with OfflinePageRequestJob
on Android? I don't know anything about that class, but that would suggest it
isn't using the file job appropriately, or can be modified in how it calls.

Lastly, I should point out that either of these approaches is only going to
allow blacklisting paths from within profile-initiated requests. file://URLs
that come from other contexts may not flow through that. Notably, I expect that
if you specify a file:// URL for a PAC script it will not go through any of
these checks as it is using a different URLRequestContext.

 #endif  // defined(OS_CHROMEOS)
 #if defined(OS_ANDROID)
   set_protocol = job_factory->SetProtocolHandler(