Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Issue 2790063007: GN: Re-generate reference.md (Closed)

Created:
3 years, 8 months ago by timn
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Re-generate reference.md Necessary because https://codereview.chromium.org/2773043005/ changed the way GN outputs newlines when generating the reference. BUG= Review-Url: https://codereview.chromium.org/2790063007 Cr-Commit-Position: refs/heads/master@{#461839} Committed: https://chromium.googlesource.com/chromium/src/+/f6b258ce5b3d4224eafd5fb73ed1b38ebf20df3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -454 lines) Patch
M tools/gn/docs/reference.md View 312 chunks +0 lines, -454 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
timn
3 years, 8 months ago (2017-04-04 18:22:48 UTC) #2
brettw
lgtm
3 years, 8 months ago (2017-04-04 19:55:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790063007/1
3 years, 8 months ago (2017-04-04 20:25:22 UTC) #5
Dirk Pranke
lgtm also.
3 years, 8 months ago (2017-04-04 20:53:29 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 21:13:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6b258ce5b3d4224eafd5fb73ed1...

Powered by Google App Engine
This is Rietveld 408576698