Merge 58: Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

Merge 58: Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

This CL makes sure that we create a HW encoder session only when
MaxFrameDelayCount can be set. In case of multiple video streams, Video
Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
should just fall back to SW in those cases.
Additional cleanups:
- Remove the unused buffer pool attributes.
- Since MaxFrameDelayCount can only be set when
RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
logic.

BUG=707309
TEST=Demo trying resolutions scaling down https://jsfiddle.net/emircan/jhonduk5/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791733002
Cr-Commit-Position: refs/heads/master@{#461245}
(cherry picked from commit 7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64)
NOTRY=true
NOPRESUBMIT=true
TBR=sandersd@chromium.org

Review-Url: https://codereview.chromium.org/2790063003
Cr-Commit-Position: refs/branch-heads/3029@{#551}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/2702ea80726ccc5647abb885927c4e23dd6ff118

[emircan, 2017-04-03 17:09:07]

Description was changed from

==========
Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

This CL makes sure that we create a HW encoder session only when
MaxFrameDelayCount can be set. In case of multiple video streams, Video
Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
should just fall back to SW in those cases.
Additional cleanups:
- Remove the unused buffer pool attributes.
- Since MaxFrameDelayCount can only be set when
RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
logic.

BUG=707309
TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791733002
Cr-Commit-Position: refs/heads/master@{#461245}
(cherry picked from commit 7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64)
==========

to

==========
Merge 58: Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

This CL makes sure that we create a HW encoder session only when
MaxFrameDelayCount can be set. In case of multiple video streams, Video
Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
should just fall back to SW in those cases.
Additional cleanups:
- Remove the unused buffer pool attributes.
- Since MaxFrameDelayCount can only be set when
RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
logic.

BUG=707309
TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791733002
Cr-Commit-Position: refs/heads/master@{#461245}
(cherry picked from commit 7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64)
NOTRY=true
NOPRESUBMIT=true
TBR=sandersd@chromium.org
==========

[emircan, 2017-04-03 17:09:46]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:15:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491239386083880, "parent_rev":
"5aa9a4a70f65068dcc5d8b84ca42cb05fb380728", "commit_rev":
"9dc3af0821a2330f1beda87d99dff3acd735a669"}

[commit-bot: I haz the power, 2017-04-03 17:20:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491239386083880, "parent_rev":
"5aa9a4a70f65068dcc5d8b84ca42cb05fb380728", "commit_rev":
"9dc3af0821a2330f1beda87d99dff3acd735a669"}

[commit-bot: I haz the power, 2017-04-03 17:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491239386083880, "parent_rev":
"5aa9a4a70f65068dcc5d8b84ca42cb05fb380728", "commit_rev":
"9dc3af0821a2330f1beda87d99dff3acd735a669"}

[commit-bot: I haz the power, 2017-04-03 17:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:28:03]

Failed to commit the patch.

[emircan, 2017-04-03 17:35:04]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 17:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:35:52]

Dry run: This issue passed the CQ dry run.

[emircan, 2017-04-03 17:40:09]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 17:40:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:40:43]

Dry run: This issue passed the CQ dry run.

[emircan, 2017-04-03 17:57:16]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 18:01:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491242236989570, "parent_rev":
"1cf256a94ec3225b1e238f5d63d375600fd251fa", "commit_rev":
"2702ea80726ccc5647abb885927c4e23dd6ff118"}

[commit-bot: I haz the power, 2017-04-03 18:02:21]

Description was changed from

==========
Merge 58: Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

This CL makes sure that we create a HW encoder session only when
MaxFrameDelayCount can be set. In case of multiple video streams, Video
Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
should just fall back to SW in those cases.
Additional cleanups:
- Remove the unused buffer pool attributes.
- Since MaxFrameDelayCount can only be set when
RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
logic.

BUG=707309
TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791733002
Cr-Commit-Position: refs/heads/master@{#461245}
(cherry picked from commit 7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64)
NOTRY=true
NOPRESUBMIT=true
TBR=sandersd@chromium.org
==========

to

==========
Merge 58: Enforce MaxFrameDelayCount in VTVideoEncodeAccelerator and cleanups

This CL makes sure that we create a HW encoder session only when
MaxFrameDelayCount can be set. In case of multiple video streams, Video
Toolbox can set this variable up to 8, which results in a ~240 ms delay. We
should just fall back to SW in those cases.
Additional cleanups:
- Remove the unused buffer pool attributes.
- Since MaxFrameDelayCount can only be set when
RequireHardwareAcceleratedVideoEncoder works, remove the other fallback
logic.

BUG=707309
TEST=Demo trying resolutions scaling down
https://jsfiddle.net/emircan/jhonduk5/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791733002
Cr-Commit-Position: refs/heads/master@{#461245}
(cherry picked from commit 7cfd3f9eb9dd016c64853f1ae8af84980f9d6f64)
NOTRY=true
NOPRESUBMIT=true
TBR=sandersd@chromium.org

Review-Url: https://codereview.chromium.org/2790063003
Cr-Commit-Position: refs/branch-heads/3029@{#551}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/2702ea80726ccc5647abb885927c...
==========

[commit-bot: I haz the power, 2017-04-03 18:02:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2702ea80726ccc5647abb885927c...