Accessible bounds should include device scale factor on Windows (again)

Accessible bounds should include device scale factor on Windows (again)

The previous patch (https://codereview.chromium.org/2759903002)
attempted to fix this bug, but I unknowingly tested it with buggy AT.

I've now determined that inspect.exe, Narrator, and ZoomText all seem
to be doing the right thing. This patch fixes the bounding boxes for
those three tools.

Others, including NVDA with the focus highlight add-on, and
accExplorer, show the wrong bounding box and should be fixed to
be dpi-aware.

BUG=694605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2789963002
Cr-Commit-Position: refs/heads/master@{#461547}
Committed: https://chromium.googlesource.com/chromium/src/+/a62e4692a41ec371137ad9bd94b1b51b91e7192b

[dmazzoni, 2017-03-31 23:03:37]

Description was changed from

==========
Device scale factor 2

BUG=
==========

to

==========
Device scale factor 2

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2017-03-31 23:10:29]

Description was changed from

==========
Device scale factor 2

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Accessible bounds should include device scale factor on Windows (again)

The previous patch (https://codereview.chromium.org/2759903002)
attempted to fix this bug, but I unknowingly tested it with buggy AT.

I've now determined that inspect.exe, Narrator, and ZoomText all seem
to be doing the right thing. This patch fixes the bounding boxes for
those three tools.

Others, including NVDA with the focus highlight add-on, and
accExplorer, show the wrong bounding box and should be fixed to
be dpi-aware.

BUG=694605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2017-03-31 23:10:29]

dmazzoni@chromium.org changed reviewers:
+ dougt@chromium.org, nektar@chromium.org, patricialor@chromium.org

[dmazzoni, 2017-03-31 23:14:09]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 23:14:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 23:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 23:18:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2017-04-02 18:50:26]

+ // Override the bounds calculation to take the device scale factor
+ // into account, which doesn't need to be done on all platforms.
+ CONTENT_EXPORT gfx::Rect RelativeToAbsoluteBounds(
+ gfx::RectF bounds,
+ bool frame_only) const override;

1. Why is a private method exported?
2. Are you overriding a method and then simply calling the base class
implementation?

[dmazzoni, 2017-04-03 17:06:46]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 17:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-04-03 17:11:44]

Rebased. You're right, I ended up with a useless override.
I fixed that, the patch should be reasonable now.

[commit-bot: I haz the power, 2017-04-03 17:20:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:20:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-04-03 18:08:33]

lgtm

[dmazzoni, 2017-04-03 20:32:35]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:38:23]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-03 21:40:19]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-04-03 21:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/2789963002/#ps80001
(title: "Fix const")

[commit-bot: I haz the power, 2017-04-03 21:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:45:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491255619948520,
"parent_rev": "8054305d4a8aa57e06ef3e5012bf985305bc364d", "commit_rev":
"6a95d668f7df11a1b18417c059534c69a7b198c9"}

[commit-bot: I haz the power, 2017-04-03 21:51:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491255619948520,
"parent_rev": "e3b13aecec9bb2473c003adb2d8e7dd0f350c9e7", "commit_rev":
"a62e4692a41ec371137ad9bd94b1b51b91e7192b"}

[commit-bot: I haz the power, 2017-04-03 21:53:26]

Description was changed from

==========
Accessible bounds should include device scale factor on Windows (again)

The previous patch (https://codereview.chromium.org/2759903002)
attempted to fix this bug, but I unknowingly tested it with buggy AT.

I've now determined that inspect.exe, Narrator, and ZoomText all seem
to be doing the right thing. This patch fixes the bounding boxes for
those three tools.

Others, including NVDA with the focus highlight add-on, and
accExplorer, show the wrong bounding box and should be fixed to
be dpi-aware.

BUG=694605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Accessible bounds should include device scale factor on Windows (again)

The previous patch (https://codereview.chromium.org/2759903002)
attempted to fix this bug, but I unknowingly tested it with buggy AT.

I've now determined that inspect.exe, Narrator, and ZoomText all seem
to be doing the right thing. This patch fixes the bounding boxes for
those three tools.

Others, including NVDA with the focus highlight add-on, and
accExplorer, show the wrong bounding box and should be fixed to
be dpi-aware.

BUG=694605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2789963002
Cr-Commit-Position: refs/heads/master@{#461547}
Committed:
https://chromium.googlesource.com/chromium/src/+/a62e4692a41ec371137ad9bd94b1...
==========

[commit-bot: I haz the power, 2017-04-03 21:53:27]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a62e4692a41ec371137ad9bd94b1...