Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html

Issue 2789883002: setValueCurveAtTime takes sequence<float> for curve (Closed)
Patch Set: Use references; fix merge mistake. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
index a406e05e8c86de641286f1c27250764e73f9e07a..5b33ac5909e30d7fe072edd967d066cac0d7c768 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
@@ -106,7 +106,13 @@
'gain.gain.setValueCurveAtTime(curve, 1, ' + duration + ')')
.throw();
}
-
+ // Non-finite curve values should signal an error
hongchan 2017/04/11 17:12:24 super nit: a period at the end.
Raymond Toy 2017/04/11 20:11:00 Done.
+ for (curve of [[1, 2, Infinity, 3], [1, NaN, 2, 3]]) {
+ should(
+ () => gain.gain.setValueCurveAtTime(curve, 1, 1),
+ 'gain.gain.setValueCurveAtTime([' + curve + '], 1, 1)')
+ .throw();
+ }
task.done();
});
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698