Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2789873003: Enable AddExpiredThenUpdate on MACOSX (Closed)

Created:
3 years, 8 months ago by Gang Wu
Modified:
3 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable AddExpiredThenUpdate on MACOSX BUG=115526, 707303 Review-Url: https://codereview.chromium.org/2789873003 Cr-Commit-Position: refs/heads/master@{#461493} Committed: https://chromium.googlesource.com/chromium/src/+/3e89c40768f9ed6488cd9d468b3a3e6fea3ec137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Gang Wu
It seems good on macosx now.
3 years, 8 months ago (2017-04-03 16:10:07 UTC) #7
Nicolas Zea
lgtm
3 years, 8 months ago (2017-04-03 17:44:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789873003/1
3 years, 8 months ago (2017-04-03 18:14:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 18:55:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e89c40768f9ed6488cd9d468b3a...

Powered by Google App Engine
This is Rietveld 408576698