[Payments] Upload card UI now has a CVC prompt

chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc

Index: chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc b/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
index 9689355727f31bdfc495d4582a57f41668b0298f..18e320b13346d0be7e6f18a7eca863f6a66eb421 100644
--- a/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
+++ b/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
@@ -77,6 +77,7 @@ class SaveCardBubbleControllerImplTest : public BrowserWithTestWindowTest {
     std::unique_ptr<base::DictionaryValue> legal_message =
         dictionary->CreateDeepCopy();
     controller()->ShowBubbleForUpload(CreditCard(), std::move(legal_message),
+                                      bool() /* should_cvc_be_requested */,

[Evan Stade, 2017/04/07 02:14:39]

This should be false, rather than bool().

Could you add test coverage for the request CVC case?

[Jared Saul, 2017/04/08 01:05:36]

Added tests for ShouldRequestCvcFromUser()'s value and the metrics happy path
case.  Question: Should I reproduce all of the metrics tests?  If so, is there
an easy to way to true/false parameterize tests in Chrome so I don't need to
duplicate the code itself?

[Evan Stade, 2017/04/10 18:32:09]

you can use TEST_P for parameterization but what you have is fine.

[Jared Saul, 2017/04/11 00:53:05]

Acknowledged.

                                       base::Bind(&SaveCardCallback));
   }