[Payments] Upload card UI now has a CVC prompt

chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/json/json_reader.h"
@@ skipping 59 matching lines @@
   }
 
   void SetLegalMessage(const std::string& message_json) {
     std::unique_ptr<base::Value> value(base::JSONReader::Read(message_json));
     ASSERT_TRUE(value);
     base::DictionaryValue* dictionary;
     ASSERT_TRUE(value->GetAsDictionary(&dictionary));
     std::unique_ptr<base::DictionaryValue> legal_message =
         dictionary->CreateDeepCopy();
     controller()->ShowBubbleForUpload(CreditCard(), std::move(legal_message),
+                                      bool() /* should_cvc_be_requested */,

[Evan Stade, 2017/04/07 02:14:39]

This should be false, rather than bool().

Could you add test coverage for the request CVC case?

[Jared Saul, 2017/04/08 01:05:36]

Added tests for ShouldRequestCvcFromUser()'s value and the metrics happy path
case.  Question: Should I reproduce all of the metrics tests?  If so, is there
an easy to way to true/false parameterize tests in Chrome so I don't need to
duplicate the code itself?

[Evan Stade, 2017/04/10 18:32:09]

you can use TEST_P for parameterization but what you have is fine.

[Jared Saul, 2017/04/11 00:53:05]

Acknowledged.

                                       base::Bind(&SaveCardCallback));
   }
 
   void ShowLocalBubble() {
     controller()->ShowBubbleForLocalSave(CreditCard(),
                                          base::Bind(&SaveCardCallback));
   }
 
   void ShowUploadBubble() {
     SetLegalMessage(
@@ skipping 277 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
           "Autofill.SaveCreditCardPrompt.Upload.FirstShow"),
       ElementsAre(
           Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
           Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_INVALID_LEGAL_MESSAGE,
                  1)));
 }
 
 }  // namespace autofill