[Payments] Upload card UI now has a CVC prompt

components/autofill/core/browser/ui/save_card_bubble_controller.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
-#define CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/legal_message_line.h"
 #include "url/gurl.h"
 
 namespace autofill {
 
 class CreditCard;
 class SaveCardBubbleView;
 
 // Interface that exposes controller functionality to SaveCardBubbleView.
 class SaveCardBubbleController {
  public:
   // Returns the title that should be displayed in the bubble.
   virtual base::string16 GetWindowTitle() const = 0;
 
   // Returns the explanatory text that should be displayed in the bubble.
   // Returns an empty string if no message should be displayed.
   virtual base::string16 GetExplanatoryMessage() const = 0;
 
   // Returns the card that will be uploaded if the user accepts.
   virtual const CreditCard GetCard() const = 0;
 
+  // Returns the CVC image icon.
+  virtual int GetCvcImageRid() const = 0;
+
+  // Returns whether the dialog should include a field requesting the card's CVC
+  // from the user.
+  virtual bool ShouldRequestCvcFromUser() const = 0;
+
+  // Takes in the CVC provided by the user in the save card bubble (if it was
+  // not detected on the page), to be populated in the final request.

[csashi, 2017/04/02 22:36:15]

You can remove the "(if it was not detected on the page)" from this comment.
This function is not responsible for the logic on whether CVC was detected on
the page or not.

[Jared Saul, 2017/04/03 18:52:59]

Done.

+  virtual void SetCvcEnteredByUser(const base::string16& cvc) = 0;
+
+  // Returns the CVC provided by the user in the save card bubble (if it was not
+  // detected on the page).

[csashi, 2017/04/02 22:36:15]

Same as above.

[Jared Saul, 2017/04/03 18:52:59]

Done.

+  virtual base::string16 GetCvcEnteredByUser() const = 0;
+
   // Interaction.
   virtual void OnSaveButton() = 0;
   virtual void OnCancelButton() = 0;
   virtual void OnLearnMoreClicked() = 0;
   virtual void OnLegalMessageLinkClicked(const GURL& url) = 0;
   virtual void OnBubbleClosed() = 0;
 
   // State.
 
   // Returns empty vector if no legal message should be shown.
   virtual const LegalMessageLines& GetLegalMessageLines() const = 0;
 
+  // Utilities.
+  virtual bool InputCvcIsValid(const base::string16& input_text) const = 0;
+
  protected:
   SaveCardBubbleController() {}
   virtual ~SaveCardBubbleController() {}
 
   DISALLOW_COPY_AND_ASSIGN(SaveCardBubbleController);
 };
 
 }  // namespace autofill
 
-#endif  // CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_