Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2789843004: [Payments] Upload card UI now has a CVC prompt (Closed)
Patch Set: Addressing code review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <string> 9 #include <string>
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // been able to get upload details. 73 // been able to get upload details.
74 UPLOAD_NOT_OFFERED_NO_ZIP_CODE, 74 UPLOAD_NOT_OFFERED_NO_ZIP_CODE,
75 // A CVC, one or more valid addresses, and a name were available but the 75 // A CVC, one or more valid addresses, and a name were available but the
76 // request to Payments for upload details failed. 76 // request to Payments for upload details failed.
77 UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED, 77 UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED,
78 // A CVC and one or more addresses were available but the names on the card 78 // A CVC and one or more addresses were available but the names on the card
79 // and/or the addresses didn't match. We don't know whether the address(es) 79 // and/or the addresses didn't match. We don't know whether the address(es)
80 // were otherwise valid nor whether we would have been able to get upload 80 // were otherwise valid nor whether we would have been able to get upload
81 // details. 81 // details.
82 UPLOAD_NOT_OFFERED_CONFLICTING_NAMES, 82 UPLOAD_NOT_OFFERED_CONFLICTING_NAMES,
83 // No CVC was detected, but valid addresses and names were. Upload is still
84 // possible if the user manually enters CVC, so upload was offered.
85 UPLOAD_OFFERED_NO_CVC,
83 NUM_CARD_UPLOAD_DECISION_METRICS, 86 NUM_CARD_UPLOAD_DECISION_METRICS,
84 }; 87 };
85 88
86 enum DeveloperEngagementMetric { 89 enum DeveloperEngagementMetric {
87 // Parsed a form that is potentially autofillable. 90 // Parsed a form that is potentially autofillable.
88 FILLABLE_FORM_PARSED = 0, 91 FILLABLE_FORM_PARSED = 0,
89 // Parsed a form that is potentially autofillable and contains at least one 92 // Parsed a form that is potentially autofillable and contains at least one
90 // web developer-specified field type hint, a la 93 // web developer-specified field type hint, a la
91 // http://is.gd/whatwg_autocomplete 94 // http://is.gd/whatwg_autocomplete
92 FILLABLE_FORM_CONTAINS_TYPE_HINTS, 95 FILLABLE_FORM_CONTAINS_TYPE_HINTS,
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 FormFieldData last_polled_field_; 763 FormFieldData last_polled_field_;
761 }; 764 };
762 765
763 private: 766 private:
764 DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics); 767 DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
765 }; 768 };
766 769
767 } // namespace autofill 770 } // namespace autofill
768 771
769 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 772 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698