Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2789783002: MD Settings: Restore focus after closing dialogs, for passwords page. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore focus after closing dialogs, for passwords page. BUG=668313 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2789783002 Cr-Commit-Position: refs/heads/master@{#461172} Committed: https://chromium.googlesource.com/chromium/src/+/653ec948f369a89d8f2f6a7e6afbb323d9fb82ee

Patch Set 1 : nit #

Patch Set 2 : fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 5 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 1 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
dpapad
3 years, 8 months ago (2017-03-31 01:43:00 UTC) #10
hcarmona
lgtm
3 years, 8 months ago (2017-03-31 16:42:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789783002/40001
3 years, 8 months ago (2017-03-31 17:36:59 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 18:14:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/653ec948f369a89d8f2f6a7e6afb...

Powered by Google App Engine
This is Rietveld 408576698