Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2789773002: Defer AVDA codec creation during reset. (Closed)

Created:
3 years, 8 months ago by liberato (no reviews please)
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Defer AVDA codec creation during reset. When seeking, AVDA needs to flush or replace the codec instance. Previously, it would do so on every AVDA::Reset, which would cause ~8 codecs/sec while scrubbing. This CL causes AVDA to defer codec destruction for Reset() like it already does for flush. The result is ~2 codecs / second. BUG=598385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2789773002 Cr-Commit-Position: refs/heads/master@{#460941} Committed: https://chromium.googlesource.com/chromium/src/+/8bf705dd67877f6708eb45ba35ced816013eba5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
liberato (no reviews please)
3 years, 8 months ago (2017-03-30 21:51:42 UTC) #4
DaleCurtis
lgtm, I thought this had changed since inception, but it hasn't, and I don't remember ...
3 years, 8 months ago (2017-03-30 22:02:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789773002/1
3 years, 8 months ago (2017-03-30 22:52:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:54:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bf705dd67877f6708eb45ba35ce...

Powered by Google App Engine
This is Rietveld 408576698