Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 2789713003: [turbofan] load elimination looks through TypeGuards (Closed)

Created:
3 years, 8 months ago by Tobias Tebbi
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer, bmeuerer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] load elimination looks through TypeGuards R=bmeuerer@chromium.org Review-Url: https://codereview.chromium.org/2789713003 Cr-Commit-Position: refs/heads/master@{#44309} Committed: https://chromium.googlesource.com/v8/v8/+/591562c131ee58d9f72c9a2b1884861566af65b1

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/load-elimination.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tobias Tebbi
3 years, 8 months ago (2017-03-31 12:30:09 UTC) #1
Benedikt Meurer
LGTM once comment addressed. https://codereview.chromium.org/2789713003/diff/1/src/compiler/load-elimination.cc File src/compiler/load-elimination.cc (right): https://codereview.chromium.org/2789713003/diff/1/src/compiler/load-elimination.cc#newcode22 src/compiler/load-elimination.cc:22: Node* Normalize(Node* node) { Just ...
3 years, 8 months ago (2017-03-31 12:48:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789713003/20001
3 years, 8 months ago (2017-03-31 13:48:31 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:11:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/591562c131ee58d9f72c9a2b1884861566a...

Powered by Google App Engine
This is Rietveld 408576698