Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2789713002: Replace the string "icecreamsandwich" with "kitkat" in Port classes. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the string "icecreamsandwich" with "kitkat" in Port classes. I don't expect this change to have any effect on behavior. BUG=705593 Review-Url: https://codereview.chromium.org/2789713002 Cr-Commit-Position: refs/heads/master@{#460933} Committed: https://chromium.googlesource.com/chromium/src/+/8f36c8ad44b223f425bd87e2cd26de9bf35afaec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 8 months ago (2017-03-30 20:28:06 UTC) #2
jbudorick
lgtm
3 years, 8 months ago (2017-03-30 23:33:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789713002/1
3 years, 8 months ago (2017-03-30 23:36:42 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 23:45:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f36c8ad44b223f425bd87e2cd26...

Powered by Google App Engine
This is Rietveld 408576698