Cleanup Tool WebUI: Add browser_proxy javascript class

Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2789663003
Cr-Commit-Position: refs/heads/master@{#462196}
Committed: https://chromium.googlesource.com/chromium/src/+/85c82c14860ed430fba085918343d9bb7db1828c

[proberge, 2017-03-30 18:42:09]

Description was changed from

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
==========

to

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[proberge, 2017-03-30 18:43:08]

Description was changed from

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[proberge, 2017-03-30 18:43:08]

proberge@chromium.org changed reviewers:
+ ftirelo@chromium.org, tommycli@chromium.org

[Fabio Tirelo, 2017-03-30 19:25:45]

ftirelo@google.com changed reviewers:
+ ftirelo@google.com

[Fabio Tirelo, 2017-03-30 19:25:45]

lgtm

https://codereview.chromium.org/2789663003/diff/1/chrome/browser/resources/cl...
File chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js (right):

https://codereview.chromium.org/2789663003/diff/1/chrome/browser/resources/cl...
chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js:14: *      
Cleanup Tool can remove,
Nit: period at the end of each item?

[tommycli, 2017-03-30 20:12:41]

lgtm

[proberge, 2017-04-05 14:17:55]

proberge@chromium.org changed reviewers:
+ estade@chromium.org

[proberge, 2017-04-05 14:17:55]

++estade chrome/browser/browser_resources.grd OWNER reviewer

[Evan Stade, 2017-04-05 18:03:57]

grd lgtm

[proberge, 2017-04-05 18:04:25]

The CQ bit was checked by proberge@chromium.org

[proberge, 2017-04-05 18:04:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ftirelo@google.com,
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2789663003/#ps40001
(title: "Merge from committed dependent patchset")

[commit-bot: I haz the power, 2017-04-05 18:04:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[proberge, 2017-04-05 18:19:57]

The CQ bit was checked by proberge@chromium.org

[proberge, 2017-04-05 18:19:57]

The patchset sent to the CQ was uploaded after l-g-t-m from ftirelo@google.com,
tommycli@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2789663003/#ps60001
(title: "Fix indent and path of compile_js2 in compiled_resources2.gyp")

[commit-bot: I haz the power, 2017-04-05 18:20:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:46:03]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[proberge, 2017-04-05 19:01:57]

The CQ bit was checked by proberge@chromium.org

[proberge, 2017-04-05 19:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ftirelo@google.com,
tommycli@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2789663003/#ps80001
(title: "Try make closure compiler happy")

[commit-bot: I haz the power, 2017-04-05 19:02:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-04-05 19:41:25]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-04-05 19:41:26]

when will the code you're adding to chrome (that all our windows users download)
actually do something?

I don't see where the browser proxy is actually used.

chrome.send('requestLastScanResult') would crash chrome (at least in debug)
because there's no C++ handler for that message.

splitting CLs into smaller bits is helpful, but please try to use the code
you're adding or hide it behind a compile flag until it is used.

https://codereview.chromium.org/2789663003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js (right):

https://codereview.chromium.org/2789663003/diff/80001/chrome/browser/resource...
chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js:16: * }};
}}; -> }}

[proberge, 2017-04-05 20:06:06]

On 2017/04/05 19:41:26, Dan Beam wrote:
> when will the code you're adding to chrome (that all our windows users
download)
> actually do something?
> 
> I don't see where the browser proxy is actually used.
> 
> chrome.send('requestLastScanResult') would crash chrome (at least in debug)
> because there's no C++ handler for that message.
> 
> splitting CLs into smaller bits is helpful, but please try to use the code
> you're adding or hide it behind a compile flag until it is used.
> 
>
https://codereview.chromium.org/2789663003/diff/80001/chrome/browser/resource...
> File chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js (right):
> 
>
https://codereview.chromium.org/2789663003/diff/80001/chrome/browser/resource...
> chrome/browser/resources/cleanup_tool/cleanup_browser_proxy.js:16: * }};
> }}; -> }}

The action handler (returning dummy data) was submitted in the (committed)
dependent patchset:
https://codereview.chromium.org/2784653004/diff/180001/chrome/browser/ui/webu...

requestLastScanResult will be called from JS once depending patchset
https://codereview.chromium.org/2788743002/ is submitted.

[commit-bot: I haz the power, 2017-04-05 20:18:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491418917586630,
"parent_rev": "f08eca2d6424844f316f3febab1411b64efa79f3", "commit_rev":
"85c82c14860ed430fba085918343d9bb7db1828c"}

[commit-bot: I haz the power, 2017-04-05 20:19:35]

Description was changed from

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup Tool WebUI: Add browser_proxy javascript class

cleanup_browser_proxy.js will be responsible for the communication
between the C++ code and the JS/HTML contents.

BUG=2784653004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2789663003
Cr-Commit-Position: refs/heads/master@{#462196}
Committed:
https://chromium.googlesource.com/chromium/src/+/85c82c14860ed430fba085918343...
==========

[commit-bot: I haz the power, 2017-04-05 20:19:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/85c82c14860ed430fba085918343...