Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2789623004: Clamp focus ring opacity to avoid debug-mode failures (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, davemoore+watch_chromium.org, sky, Alexander Alekseev
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp focus ring opacity to avoid debug-mode failures BUG=706668 Review-Url: https://codereview.chromium.org/2789623004 Cr-Commit-Position: refs/heads/master@{#460951} Committed: https://chromium.googlesource.com/chromium/src/+/9a31be0e1cc31d7aba42d5131ce5621d589a07e6

Patch Set 1 #

Patch Set 2 : Use float constants explicitly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dmazzoni
3 years, 8 months ago (2017-03-30 21:43:19 UTC) #2
xiyuan
lgtm
3 years, 8 months ago (2017-03-30 21:49:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789623004/1
3 years, 8 months ago (2017-03-30 22:16:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/395230)
3 years, 8 months ago (2017-03-30 22:36:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789623004/20001
3 years, 8 months ago (2017-03-30 23:31:40 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:28:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a31be0e1cc31d7aba42d5131ce5...

Powered by Google App Engine
This is Rietveld 408576698