Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2789593002: [inspector] don't use v8::Isolate::GetCurrent in V8StackTraceImpl (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] don't use v8::Isolate::GetCurrent in V8StackTraceImpl In inspector code everywhere except V8StackTraceImpl we get pointer to isolate from inspector object or v8::FunctionCallbackInfo. We can avoid usage of v8::Isolate::GetCurrent in V8StackTraceImpl too. It will simplify a little embedder code by removing requirement to have v8::Isolate::Scope before calling to V8InspectorSession::dispatchProtocolMessage. BUG=v8:5907 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2789593002 Cr-Commit-Position: refs/heads/master@{#44282} Committed: https://chromium.googlesource.com/v8/v8/+/8adf294cb4700e069f3da27b941417560a68e5f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/inspector/v8-console.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-stack-trace-impl.cc View 6 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kozy
Dmitry, please take a look.
3 years, 8 months ago (2017-03-30 16:17:52 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-03-30 21:10:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789593002/1
3 years, 8 months ago (2017-03-30 21:51:09 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 22:17:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8adf294cb4700e069f3da27b941417560a6...

Powered by Google App Engine
This is Rietveld 408576698