Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2789583002: Don't add quotes for testing config feature command line flags. (Closed)

Created:
3 years, 8 months ago by Alexei Svitkine (slow)
Modified:
3 years, 8 months ago
Reviewers:
perezju
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't add quotes for testing config feature command line flags. I added these in https://codereview.chromium.org/2778313003/, but turns out perfbot infra doesn't use the shell for the command line used, so they're not necessary and would in fact cause problems as the starts/ends of the feature lists would have leading and trailing quotes and would not be interpreted correctly by Chrome. PERF SHERIFFS: This CL may move metrics as it fixes a bug in the evaluation of field trial testing config. BUG=706414 Review-Url: https://codereview.chromium.org/2789583002 Cr-Commit-Position: refs/heads/master@{#460779} Committed: https://chromium.googlesource.com/chromium/src/+/e376f4717780e3248c359ea4fd5e47976130cc0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/variations/fieldtrial_util.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/variations/fieldtrial_util_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Alexei Svitkine (slow)
3 years, 8 months ago (2017-03-30 15:16:59 UTC) #2
perezju
lgtm
3 years, 8 months ago (2017-03-30 15:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789583002/1
3 years, 8 months ago (2017-03-30 15:26:47 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 15:59:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e376f4717780e3248c359ea4fd5e...

Powered by Google App Engine
This is Rietveld 408576698