Issue 278953002: DevTools: allow inspecting browsers using custom front-ends.

Issue 278953002: DevTools: allow inspecting browsers using custom front-ends. (Closed)

Created:
6 years, 7 months ago by pfeldman

Modified:
6 years, 7 months ago

Reviewers:
r.kasibhatla, nduca, Vladislav Kaznacheev, Sami

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: allow inspecting browsers using custom front-ends. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271052

Patch Set 2 : With the link in the UI. #

Patch Set 3 : Manually tested end-to-end. #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -3 lines)			Patch
M	chrome/browser/devtools/device/devtools_android_bridge.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/device/devtools_android_bridge.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_targets_ui.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_targets_ui.cc	View		4 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/browser/resources/inspect/inspect.css	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.js	View	1 2	2 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View	1 2	6 chunks	+58 lines, -0 lines	1 comment	Download
M	content/browser/devtools/devtools_browser_target.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/devtools/devtools_tracing_handler.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

pfeldman

This adds InspectUI::InspectBrowserWithCustomFrontend which _should_ work, but I only know that it compiles. Theoretically, any ...

6 years, 7 months ago (2014-05-09 19:30:02 UTC) #1

pfeldman

By no means I have been running this code :) So the missing bits are: ...

6 years, 7 months ago (2014-05-09 19:39:38 UTC) #2

pfeldman

Alright, it works now. How to demo: 1. Run dummy front-end off localhost:8081. See front-end ...

6 years, 7 months ago (2014-05-16 13:12:58 UTC) #3

Vladislav Kaznacheev

https://codereview.chromium.org/278953002/diff/60001/chrome/browser/ui/webui/inspect_ui.cc File chrome/browser/ui/webui/inspect_ui.cc (right): https://codereview.chromium.org/278953002/diff/60001/chrome/browser/ui/webui/inspect_ui.cc#newcode275 chrome/browser/ui/webui/inspect_ui.cc:275: // Create web contents for the front-end. This class ...

6 years, 7 months ago (2014-05-16 13:38:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/278953002/60001

6 years, 7 months ago (2014-05-16 16:03:03 UTC) #8

Message was sent while issue was closed.

Change committed as 271052

Expand Messages | Collapse Messages