content/browser/devtools/devtools_tracing_handler.cc - Issue 278953002: DevTools: allow inspecting browsers using custom front-ends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_tracing_handler.cc

Issue 278953002: DevTools: allow inspecting browsers using custom front-ends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Manually tested end-to-end. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_tracing_handler.cc

diff --git a/content/browser/devtools/devtools_tracing_handler.cc b/content/browser/devtools/devtools_tracing_handler.cc

index ffe02c1df26c33545bdfe0ae1fbc7440b7ed46db..977f88e6945386aa41c496b582a7a84e7f569a9d 100644

--- a/content/browser/devtools/devtools_tracing_handler.cc

+++ b/content/browser/devtools/devtools_tracing_handler.cc

@@ -171,7 +171,7 @@ DevToolsTracingHandler::OnStart(

TracingController::GetInstance()->EnableRecording(

categories, options, TracingController::EnableRecordingDoneCallback());

- return NULL;

+ return command->SuccessResponse(NULL);

}

void DevToolsTracingHandler::OnBufferUsage(float usage) {