Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 2789473002: libxml2: Disable unused XINCLUDE and SCHEMAS, and missing VALID on Mac. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Oliver Chang, scottmg
CC:
chromium-reviews, dominicc+watchlist_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

libxml2: Disable unused XINCLUDE and SCHEMAS, and missing VALID on Mac. LIBXML_VALID_ENABLED should have been undefined in r460360, but it looks like I missed it. BUG=692731 Review-Url: https://codereview.chromium.org/2789473002 Cr-Commit-Position: refs/heads/master@{#460977} Committed: https://chromium.googlesource.com/chromium/src/+/ec4a8e3a9d0000eaaefe7a02bd2a405bf510d49d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libxml/linux/include/libxml/xmlversion.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libxml/mac/include/libxml/xmlversion.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/libxml/win32/xmlversion.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 8 months ago (2017-03-30 11:04:53 UTC) #7
Oliver Chang
lgtm
3 years, 8 months ago (2017-03-30 16:03:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789473002/1
3 years, 8 months ago (2017-03-31 01:01:41 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:21:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec4a8e3a9d0000eaaefe7a02bd2a...

Powered by Google App Engine
This is Rietveld 408576698