Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2789463002: Clean up around RefCountedBase (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
gab, dcheng
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up around RefCountedBase There are two in-flight CLs that touches RefCountedBase. This CL is a non behavior changing part of http://crrev.com/2666423002, and reduces its confliction against http://crrev.com/2723423002. This CL contains: * Use default values on its members and simplify RefCountedBase ctor. * Simplify RefConutedBase::Release impl. Review-Url: https://codereview.chromium.org/2789463002 Cr-Commit-Position: refs/heads/master@{#460757} Committed: https://chromium.googlesource.com/chromium/src/+/6f3586e7de633c64aa318bdcf281f2d9edc4d93f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M base/memory/ref_counted.h View 3 chunks +10 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
tzik
PTAL
3 years, 8 months ago (2017-03-30 09:02:02 UTC) #8
gab
lgtm I'll CQ to make an attempt at landing https://codereview.chromium.org/2666423002/ overnight for you :), thanks!
3 years, 8 months ago (2017-03-30 14:32:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789463002/20001
3 years, 8 months ago (2017-03-30 14:33:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6f3586e7de633c64aa318bdcf281f2d9edc4d93f
3 years, 8 months ago (2017-03-30 15:14:50 UTC) #17
dcheng
3 years, 8 months ago (2017-03-30 18:42:20 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698