Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2789433002: Update src/device OWNERS files with TEAM / COMPONENTS and removing emeritus. (Closed)

Created:
3 years, 8 months ago by scheib
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-sensors_chromium.org, ortuno+watch_chromium.org, riju_, scheib+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update src/device OWNERS files with TEAM / COMPONENTS and removing emeritus. device-dev@chromium.org now exists and is taking on triage of most of src/device. This change associates the TEAM in OWNERS files and updates component labels as well. The root device/OWNERS sets the TEAM that is used in most subdirectories. Bluetooth has a specific team list, and has components added. Redundant OWNERS files are removed. mvanouwerkerk@chromium.org is removed, as they now work in other areas. geolocation does not need a redundant COMPONENT in the interfaces directory. media_transfer_protocol given Media component. Review-Url: https://codereview.chromium.org/2789433002 Cr-Commit-Position: refs/heads/master@{#461263} Committed: https://chromium.googlesource.com/chromium/src/+/82e698b4a53d8592222d7e641275f14057665f4e

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments, removing changes to device/screen_orientation/OWNERS #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M device/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
D device/bluetooth/android/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
D device/bluetooth/test/android/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M device/gamepad/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M device/geolocation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M device/geolocation/public/interfaces/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
M device/media_transfer_protocol/OWNERS View 1 chunk +2 lines, -0 lines 2 comments Download
M device/vibration/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (17 generated)
scheib
mvanouwerkerk@google.com Please verify your removal. mlamouri@chromium.org Please verify or suggest COMPONENT to use for media_transfer_protocol ...
3 years, 8 months ago (2017-03-30 04:28:38 UTC) #3
Michael van Ouwerkerk
lgtm
3 years, 8 months ago (2017-03-30 09:31:15 UTC) #5
timvolodine
https://codereview.chromium.org/2789433002/diff/1/device/sensors/OWNERS File device/sensors/OWNERS (left): https://codereview.chromium.org/2789433002/diff/1/device/sensors/OWNERS#oldcode3 device/sensors/OWNERS:3: # COMPONENT: IO>DeviceOrientation this OWNERS file is actually being ...
3 years, 8 months ago (2017-03-30 10:36:29 UTC) #7
mlamouri (slow - plz ping)
lgtm with the comment applied. https://codereview.chromium.org/2789433002/diff/1/device/screen_orientation/OWNERS File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2789433002/diff/1/device/screen_orientation/OWNERS#newcode4 device/screen_orientation/OWNERS:4: # COMPONENT: Internals>Media Not ...
3 years, 8 months ago (2017-03-30 11:00:18 UTC) #8
scheib
reillyg PTAL https://codereview.chromium.org/2789433002/diff/1/device/screen_orientation/OWNERS File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2789433002/diff/1/device/screen_orientation/OWNERS#newcode4 device/screen_orientation/OWNERS:4: # COMPONENT: Internals>Media On 2017/03/30 11:00:18, mlamouri ...
3 years, 8 months ago (2017-03-30 18:03:15 UTC) #11
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-03-31 21:15:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789433002/20001
3 years, 8 months ago (2017-03-31 21:38:13 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/82e698b4a53d8592222d7e641275f14057665f4e
3 years, 8 months ago (2017-03-31 22:57:56 UTC) #24
Lei Zhang
https://codereview.chromium.org/2789433002/diff/20001/device/media_transfer_protocol/OWNERS File device/media_transfer_protocol/OWNERS (right): https://codereview.chromium.org/2789433002/diff/20001/device/media_transfer_protocol/OWNERS#newcode4 device/media_transfer_protocol/OWNERS:4: # COMPONENT: Internals>Media Not sure why you didn't ask ...
3 years, 8 months ago (2017-04-18 02:09:34 UTC) #26
scheib
https://codereview.chromium.org/2789433002/diff/20001/device/media_transfer_protocol/OWNERS File device/media_transfer_protocol/OWNERS (right): https://codereview.chromium.org/2789433002/diff/20001/device/media_transfer_protocol/OWNERS#newcode4 device/media_transfer_protocol/OWNERS:4: # COMPONENT: Internals>Media On 2017/04/18 02:09:34, Lei Zhang wrote: ...
3 years, 8 months ago (2017-04-18 18:19:27 UTC) #27
Lei Zhang
3 years, 8 months ago (2017-04-18 18:45:08 UTC) #28
Message was sent while issue was closed.
On 2017/04/18 18:19:27, scheib wrote:
> Platform>Apps>FileManager SGTM, I'll push a new patch.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698