Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2789413003: Make AppWindowCreateFunction UIThreadExtensionFunction. (Closed)

Created:
3 years, 8 months ago by lazyboy
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AppWindowCreateFunction UIThreadExtensionFunction. AsyncExtensionFunction is deprecated. Also rename app_window tests to *AppWindowApiTest instead of *PlatformAppBrowserTest. BUG=648275 Test=Expect no visible changes. Review-Url: https://codereview.chromium.org/2789413003 Cr-Commit-Position: refs/heads/master@{#461876} Committed: https://chromium.googlesource.com/chromium/src/+/80b39f01869d523307a6b494167fdf4f3e533b53

Patch Set 1 #

Patch Set 2 : rename tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -77 lines) Patch
M extensions/browser/api/app_window/app_window_api.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 14 chunks +44 lines, -48 lines 0 comments Download
M extensions/browser/api/app_window/app_window_apitest.cc View 1 8 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lazyboy
3 years, 8 months ago (2017-04-04 20:49:26 UTC) #5
Devlin
lgtm; thanks for doing this!
3 years, 8 months ago (2017-04-04 22:27:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789413003/20001
3 years, 8 months ago (2017-04-04 22:29:05 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 22:51:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80b39f01869d523307a6b494167f...

Powered by Google App Engine
This is Rietveld 408576698