Remove an unused QuicStreamFactory::Job constructor

Remove an unused QuicStreamFactory::Job constructor

Removes an unused Job constructor and add const-ness to a few member fields.

BUG=704953
Review-Url: https://codereview.chromium.org/2789403002
Cr-Commit-Position: refs/heads/master@{#462130}
Committed: https://chromium.googlesource.com/chromium/src/+/385c750bda55aeca96a2b55c30d1f56b6a816f57

[xunjieli, 2017-04-04 18:05:34]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 18:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-04-04 18:06:23]

xunjieli@chromium.org changed reviewers:
+ zhongyi@chromium.org

[xunjieli, 2017-04-04 18:12:59]

Description was changed from

==========
Remove an unused QuicStreamFactory::Job constructor

Removes an unused Job constructor and add const-ness to a few member fields.

BUG=704949
==========

to

==========
Remove an unused QuicStreamFactory::Job constructor

Removes an unused Job constructor and add const-ness to a few member fields.

BUG=704953
==========

[commit-bot: I haz the power, 2017-04-04 19:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:08:32]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-04-05 00:00:29]

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (left):

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:413: weak_factory_(this) {}
Tracing the history of this code, this Job was used when we tried resume
connection if the 0RTT handshake had timed out. We don't have that logic anymore
in the current world. You might want to remove the code for RESUME_CONNECT as
well. 

https://codereview.chromium.org/318993004/

[Ryan Hamilton, 2017-04-05 00:10:09]

rch@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2017-04-05 00:10:10]

lgtm

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (left):

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:413: weak_factory_(this) {}
On 2017/04/05 00:00:29, Zhongyi Shi wrote:
> Tracing the history of this code, this Job was used when we tried resume
> connection if the 0RTT handshake had timed out. We don't have that logic
anymore
> in the current world. You might want to remove the code for RESUME_CONNECT as
> well. 
> 
> https://codereview.chromium.org/318993004/

Nice catch, both of you. I agree with this suggestion.

[xunjieli, 2017-04-05 15:05:35]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 15:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-04-05 15:07:29]

Cherie: PTAL. Thanks.

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (left):

https://codereview.chromium.org/2789403002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:413: weak_factory_(this) {}
On 2017/04/05 00:10:10, Ryan Hamilton wrote:
> On 2017/04/05 00:00:29, Zhongyi Shi wrote:
> > Tracing the history of this code, this Job was used when we tried resume
> > connection if the 0RTT handshake had timed out. We don't have that logic
> anymore
> > in the current world. You might want to remove the code for RESUME_CONNECT
as
> > well. 
> > 
> > https://codereview.chromium.org/318993004/
> 
> Nice catch, both of you. I agree with this suggestion.

Done. Good catch! The tests added in that CL are all passing, so I didn't touch
them. PTAL.

[Zhongyi Shi, 2017-04-05 15:09:41]

lgtm! Thanks for doing this!

[xunjieli, 2017-04-05 15:10:41]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-04-05 15:10:48]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-04-05 15:10:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2789403002/#ps20001
(title: "remove ResumeConnect() per suggestion")

[commit-bot: I haz the power, 2017-04-05 15:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 17:24:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491405048234600,
"parent_rev": "eafdfdb6623fccf2b2733d286f1e9a29d9784f66", "commit_rev":
"385c750bda55aeca96a2b55c30d1f56b6a816f57"}

[commit-bot: I haz the power, 2017-04-05 17:25:16]

Description was changed from

==========
Remove an unused QuicStreamFactory::Job constructor

Removes an unused Job constructor and add const-ness to a few member fields.

BUG=704953
==========

to

==========
Remove an unused QuicStreamFactory::Job constructor

Removes an unused Job constructor and add const-ness to a few member fields.

BUG=704953

Review-Url: https://codereview.chromium.org/2789403002
Cr-Commit-Position: refs/heads/master@{#462130}
Committed:
https://chromium.googlesource.com/chromium/src/+/385c750bda55aeca96a2b55c30d1...
==========

[commit-bot: I haz the power, 2017-04-05 17:25:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/385c750bda55aeca96a2b55c30d1...