Add mojo data types for CopylessPaste

Add mojo data types for CopylessPaste

BUG=693650
Review-Url: https://codereview.chromium.org/2789313002
Cr-Commit-Position: refs/heads/master@{#462007}
Committed: https://chromium.googlesource.com/chromium/src/+/2a7385630468cde3f9d8ca32204f27592264cb2f

[wychen, 2017-04-04 00:01:02]

Description was changed from

==========
Add mojo datatypes for CopylessPaste

BUG=693650
==========

to

==========
Add mojo data types for CopylessPaste

BUG=693650
==========

[wychen, 2017-04-04 00:01:02]

wychen@chromium.org changed reviewers:
+ dcheng@chromium.org

[wychen, 2017-04-04 00:01:48]

PTAL
I extracted the data type as a standalone CL to unblock the parsing logic.
The mojo interface will be handled in other CLs.

[dcheng, 2017-04-04 06:30:21]

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:7:
union Values {
Nit: please add some comments that document the different data types here and
what the fields mean/how they're used/how they're related/other relevant
info/etc, it's pretty opaque atm.

It looks like there's some sort of tree structure with
Entity.properties.values.entity_values, but it would be nice to document it.

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:25:
string url;
Please use url.mojom.Url.

[wychen, 2017-04-05 00:57:23]

Patchset #2 (id:20001) has been deleted

[wychen, 2017-04-05 00:57:53]

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:7:
union Values {
On 2017/04/04 06:30:21, dcheng wrote:
> Nit: please add some comments that document the different data types here and
> what the fields mean/how they're used/how they're related/other relevant
> info/etc, it's pretty opaque atm.
> 
> It looks like there's some sort of tree structure with
> Entity.properties.values.entity_values, but it would be nice to document it.

Done.

https://codereview.chromium.org/2789313002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:25:
string url;
On 2017/04/04 06:30:20, dcheng wrote:
> Please use url.mojom.Url.

Done.

[dcheng, 2017-04-05 02:39:35]

LGTM

Is this something that would make sense to typemap eventually, or are we just
going to use the Mojo struct directly?

https://codereview.chromium.org/2789313002/diff/40001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2789313002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:28:
string type; // Correspond to the "@type" key, defined in JSON-LD.
Nit: two spaces between code and comments

[wychen, 2017-04-05 06:05:40]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-05 06:05:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2789313002/#ps60001
(title: "space")

[commit-bot: I haz the power, 2017-04-05 06:05:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-05 06:06:06]

We use the Mojo types directly, so probably not necessary to do typemap.

https://codereview.chromium.org/2789313002/diff/40001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2789313002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:28:
string type; // Correspond to the "@type" key, defined in JSON-LD.
On 2017/04/05 02:39:35, dcheng wrote:
> Nit: two spaces between code and comments

Done.

[commit-bot: I haz the power, 2017-04-05 07:51:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491372340270410,
"parent_rev": "d81b3970f7e6120f5b145af37d330db86b458dba", "commit_rev":
"2a7385630468cde3f9d8ca32204f27592264cb2f"}

[commit-bot: I haz the power, 2017-04-05 07:52:49]

Description was changed from

==========
Add mojo data types for CopylessPaste

BUG=693650
==========

to

==========
Add mojo data types for CopylessPaste

BUG=693650

Review-Url: https://codereview.chromium.org/2789313002
Cr-Commit-Position: refs/heads/master@{#462007}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a7385630468cde3f9d8ca32204f...
==========

[commit-bot: I haz the power, 2017-04-05 07:52:50]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2a7385630468cde3f9d8ca32204f...