Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2789243002: Rename BluetoothScanFilterInit to BluetoothLEScanFilterInit (Closed)

Created:
3 years, 8 months ago by lunalu1
Modified:
3 years, 8 months ago
Reviewers:
haraken, ortuno, nasko
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename BluetoothScanFilterInit to BluetoothLEScanFilterInit Rename to match the spec https://webbluetoothcg.github.io/web-bluetooth/#dictdef-bluetoothlescanfilterinit BUG=707341 Review-Url: https://codereview.chromium.org/2789243002 Cr-Commit-Position: refs/heads/master@{#462111} Committed: https://chromium.googlesource.com/chromium/src/+/321635e96b5f334eb95e09898d923f3f9cedf7fb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Codereview: nit #

Total comments: 1

Patch Set 3 : Codereview: nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -77 lines) Patch
M content/browser/bluetooth/bluetooth_allowed_devices_unittest.cc View 1 2 9 chunks +20 lines, -20 lines 0 comments Download
M content/browser/bluetooth/bluetooth_blocklist.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bluetooth/bluetooth_blocklist.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_blocklist_unittest.cc View 1 2 5 chunks +27 lines, -23 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/bluetooth/bluetooth_metrics.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/bluetooth/BluetoothScanFilterInit.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/RequestDeviceOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
lunalu1
PTAL
3 years, 8 months ago (2017-04-04 13:57:10 UTC) #6
ortuno
lgtm https://codereview.chromium.org/2789243002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl File third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl (right): https://codereview.chromium.org/2789243002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl#newcode11 third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl:11: // FIXME: add the following APIs TODO(crbug.com/707635): Support ...
3 years, 8 months ago (2017-04-04 21:01:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789243002/20001
3 years, 8 months ago (2017-04-04 21:14:25 UTC) #10
lunalu1
Updated comment as suggested. Thanks
3 years, 8 months ago (2017-04-04 21:14:30 UTC) #11
lunalu1
Hi nasko, could you please owner approve web_bluetooth.mojom Hi haraken, could you please owner approve ...
3 years, 8 months ago (2017-04-04 21:25:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/402356)
3 years, 8 months ago (2017-04-04 21:29:16 UTC) #15
nasko
Rubberstamp LGTM with a nit. https://codereview.chromium.org/2789243002/diff/20001/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom File third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom (right): https://codereview.chromium.org/2789243002/diff/20001/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom#newcode100 third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:100: struct WebBluetoothLEScanFilter { nit: ...
3 years, 8 months ago (2017-04-04 23:08:32 UTC) #16
haraken
LGTM
3 years, 8 months ago (2017-04-04 23:52:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789243002/40001
3 years, 8 months ago (2017-04-05 14:58:16 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:41:46 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/321635e96b5f334eb95e09898d92...

Powered by Google App Engine
This is Rietveld 408576698