[Views] App Menu Animated Icon

chrome/browser/ui/toolbar/app_menu_icon_controller.cc

Index: chrome/browser/ui/toolbar/app_menu_icon_controller.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_icon_controller.cc b/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
index 94409738ee8860f9b759e78c599e8d1d9cf8329e..2d67da24e355e5f67395964cead480273f40ff08 100644
--- a/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
+++ b/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
@@ -40,14 +40,7 @@ AppMenuIconController::Severity SeverityFromUpgradeLevel(
 // Checks if the app menu icon should be animated for the given upgrade level.
 bool ShouldAnimateUpgradeLevel(
     UpgradeDetector::UpgradeNotificationAnnoyanceLevel level) {
-  bool should_animate = true;
-  if (level == UpgradeDetector::UPGRADE_ANNOYANCE_LOW) {
-    // Only animate low severity upgrades once.
-    static bool should_animate_low_severity = true;
-    should_animate = should_animate_low_severity;
-    should_animate_low_severity = false;
-  }
-  return should_animate;
+  return level != UpgradeDetector::UPGRADE_ANNOYANCE_NONE;
 }
 
 // Returns true if we should show the upgrade recommended icon.
@@ -121,8 +114,7 @@ void AppMenuIconController::UpdateDelegate() {
     return;
   }
 
-  delegate_->UpdateSeverity(IconType::NONE,
-                            Severity::NONE, true);
+  delegate_->UpdateSeverity(IconType::NONE, Severity::NONE, false);

[msw, 2017/04/11 17:34:13]

Why change |animate| true->false here?

[spqchan, 2017/04/12 19:42:09]

The |animate| param was actually dead code before I made this change. For the
new icon, it should not animate if the security level is NONE

 }
 
 #if defined(OS_WIN)