[Views] App Menu Animated Icon

chrome/browser/ui/toolbar/app_menu_icon_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/app_menu_icon_controller.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
@@ skipping 22 matching lines @@
     case UpgradeDetector::UPGRADE_ANNOYANCE_CRITICAL:
       return AppMenuIconController::Severity::HIGH;
   }
   NOTREACHED();
   return AppMenuIconController::Severity::NONE;
 }
 
 // Checks if the app menu icon should be animated for the given upgrade level.
 bool ShouldAnimateUpgradeLevel(
     UpgradeDetector::UpgradeNotificationAnnoyanceLevel level) {
-  bool should_animate = true;
-  if (level == UpgradeDetector::UPGRADE_ANNOYANCE_LOW) {
-    // Only animate low severity upgrades once.
-    static bool should_animate_low_severity = true;
-    should_animate = should_animate_low_severity;
-    should_animate_low_severity = false;
-  }
-  return should_animate;
+  return level != UpgradeDetector::UPGRADE_ANNOYANCE_NONE;
 }
 
 // Returns true if we should show the upgrade recommended icon.
 bool ShouldShowUpgradeRecommended() {
 #if defined(OS_CHROMEOS)
   // In chromeos, the update recommendation is shown in the system tray. So it
   // should not be displayed in the app menu.
   return false;
 #else
   return UpgradeDetector::GetInstance()->notify_upgrade();
@@ skipping 53 matching lines @@
 
   if (GlobalErrorServiceFactory::GetForProfile(profile_)
           ->GetHighestSeverityGlobalErrorWithAppMenuItem()) {
     // If you change the severity here, make sure to also change the menu icon
     // and the bubble icon.
     delegate_->UpdateSeverity(IconType::GLOBAL_ERROR,
                               Severity::MEDIUM, true);
     return;
   }
 
-  delegate_->UpdateSeverity(IconType::NONE,
-                            Severity::NONE, true);
+  delegate_->UpdateSeverity(IconType::NONE, Severity::NONE, false);

[msw, 2017/04/11 17:34:13]

Why change |animate| true->false here?

[spqchan, 2017/04/12 19:42:09]

The |animate| param was actually dead code before I made this change. For the
new icon, it should not animate if the security level is NONE

 }
 
 #if defined(OS_WIN)
 void AppMenuIconController::OnScanCompleted() {
   UpdateDelegate();
 }
 
 void AppMenuIconController::OnConflictsAcknowledged() {
   UpdateDelegate();
 }
 #endif
 
 void AppMenuIconController::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   UpdateDelegate();
 }