Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2789183003: Move PtrUtilTest.cpp to wtf_unittests. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
haraken, cblume
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PtrUtilTest.cpp to wtf_unittests. The test was part of blink_platform_unittests temporarily, because wtf_unittests was in the process of moving to platform/wtf/. Now that wtf move is complete, and we can let the test belong to the right target. BUG=707089 Review-Url: https://codereview.chromium.org/2789183003 Cr-Commit-Position: refs/heads/master@{#461641} Committed: https://chromium.googlesource.com/chromium/src/+/976a6d5640fe93c23e6aec62d2bed2230a8fdc9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Yuta Kitamura
cblume: PTAL? +haraken for approval in platform/.
3 years, 8 months ago (2017-04-04 02:30:17 UTC) #5
cblume
On 2017/04/04 02:30:17, Yuta Kitamura wrote: > cblume: PTAL? > +haraken for approval in platform/. ...
3 years, 8 months ago (2017-04-04 02:32:54 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-04 02:40:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789183003/1
3 years, 8 months ago (2017-04-04 05:56:19 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 06:04:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/976a6d5640fe93c23e6aec62d2be...

Powered by Google App Engine
This is Rietveld 408576698