Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2789183002: MD Settings: Display: Fix update order (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
malaykeshav
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display: Fix update order BUG=706473 For minor string change: TBR=rdevlin.cronin@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2789183002 Cr-Commit-Position: refs/heads/master@{#462132} Committed: https://chromium.googlesource.com/chromium/src/+/a8d1cf20deff6c710b6d096d228b65b5520c0c3c

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display.js View 5 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
stevenjb
3 years, 8 months ago (2017-04-03 16:58:51 UTC) #3
stevenjb
ping
3 years, 8 months ago (2017-04-04 21:53:06 UTC) #4
malaykeshav
lgtm
3 years, 8 months ago (2017-04-04 22:16:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789183002/20001
3 years, 8 months ago (2017-04-04 23:19:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/402511)
3 years, 8 months ago (2017-04-04 23:30:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789183002/20001
3 years, 8 months ago (2017-04-05 16:29:03 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 17:36:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8d1cf20deff6c710b6d096d228b...

Powered by Google App Engine
This is Rietveld 408576698