Update BaseBindRewriters to convert base::Bind to base::BindOnce

Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
  OnceCallback<void()> cb = base::Bind([]{});
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
  OnceCallback<void()> cb = base::BindOnce([]{});

Review-Url: https://codereview.chromium.org/2789153002
Cr-Commit-Position: refs/heads/master@{#464312}
Committed: https://chromium.googlesource.com/chromium/src/+/51e87859e8337f4cf3f9aa995884de4b786e7279

[tzik, 2017-04-03 14:02:21]

Description was changed from

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce
==========

to

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
==========

[tzik, 2017-04-03 14:02:52]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-04-03 14:02:53]

PTAL

[dcheng, 2017-04-05 16:57:37]

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right):

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:73:
target->getCallee()->IgnoreImplicit());
Out of curiosity, why do we have to IgnoreImplicit() here?

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
File tools/clang/base_bind_rewriters/tests/test-expected.cc (right):

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
tools/clang/base_bind_rewriters/tests/test-expected.cc:70: void
foo(base::OnceClosure) {}
Super minor nit: Uppercase foo() to follow Google style

Also, usually it's nice to split up the tests a bit, so we can put the callback
definitions in a common header (callback.h) and name this file something more
specific.

[tzik, 2017-04-11 07:35:13]

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
File tools/clang/base_bind_rewriters/BaseBindRewriters.cpp (right):

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
tools/clang/base_bind_rewriters/BaseBindRewriters.cpp:73:
target->getCallee()->IgnoreImplicit());
On 2017/04/05 16:57:37, dcheng wrote:
> Out of curiosity, why do we have to IgnoreImplicit() here?

Hmm, that seems unneeded. Let me remove it.
There is an ImplicitCastExpr (FunctionToPointerDecay) surrounding the
DeclRefExpr, but, as we are replacing just the last token anyway, it works well
without IgnoreImplicit.

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
File tools/clang/base_bind_rewriters/tests/test-expected.cc (right):

https://codereview.chromium.org/2789153002/diff/1/tools/clang/base_bind_rewri...
tools/clang/base_bind_rewriters/tests/test-expected.cc:70: void
foo(base::OnceClosure) {}
On 2017/04/05 16:57:37, dcheng wrote:
> Super minor nit: Uppercase foo() to follow Google style
> 
> Also, usually it's nice to split up the tests a bit, so we can put the
callback
> definitions in a common header (callback.h) and name this file something more
> specific.

Done.

[dcheng, 2017-04-12 07:38:42]

LGTM

My only nit is to rename the test file to something like:

callback-temporary-converted-to-once-callback

or something like that.

(I'm assuming we're going to add matchers for other easy to rewrite cases)

[tzik, 2017-04-13 04:44:35]

Description was changed from

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
==========

to

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
  OnceCallback<void()> cb = base::Bind([]{});
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
  OnceCallback<void()> cb = base::BindOnce([]{});
==========

[tzik, 2017-04-13 04:44:54]

On 2017/04/12 07:38:42, dcheng wrote:
> LGTM
> 
> My only nit is to rename the test file to something like:
> 
> callback-temporary-converted-to-once-callback
> 
> or something like that.
> 
> (I'm assuming we're going to add matchers for other easy to rewrite cases)

OK, done!

[tzik, 2017-04-13 04:46:53]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-04-13 04:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2789153002/#ps60001
(title: "rename test files")

[commit-bot: I haz the power, 2017-04-13 04:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:36:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492058813317050,
"parent_rev": "7178db73ead99cf38ec82a0d5a514f6612fddf2d", "commit_rev":
"51e87859e8337f4cf3f9aa995884de4b786e7279"}

[commit-bot: I haz the power, 2017-04-13 05:37:55]

Description was changed from

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
  OnceCallback<void()> cb = base::Bind([]{});
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
  OnceCallback<void()> cb = base::BindOnce([]{});
==========

to

==========
Update BaseBindRewriters to convert base::Bind to base::BindOnce

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
  OnceCallback<void()> cb = base::Bind([]{});
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
  OnceCallback<void()> cb = base::BindOnce([]{});

Review-Url: https://codereview.chromium.org/2789153002
Cr-Commit-Position: refs/heads/master@{#464312}
Committed:
https://chromium.googlesource.com/chromium/src/+/51e87859e8337f4cf3f9aa995884...
==========

[commit-bot: I haz the power, 2017-04-13 05:37:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/51e87859e8337f4cf3f9aa995884...